Cache time zone from lat/lon results #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For time zone lookup, round lat/lon to 4 digits. Ignore core_config_updated events without data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determining time zone from lat & lon can take a significant amount of time. Since time zone will not change for same lat/lon values, add a cache of calculated values. To maximize cache hits, round lat & lon to 4 digits each (which is equivalent to about 11 meters, similar to what is done for Nominatim location caching.)
Also, in update_zones, ignore events without data. For some reason, at startup, there are two core_config_updated events fired (with no data), even though the core config has not actually changed. Ignoring these eliminates unnecessary time zone lookups for HA zones.