Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unnecessary call to escapeSvelte #636

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Conversation

benmccann
Copy link
Contributor

I had it there because it's what I've seen in all the examples around the community, but as @theetrain pointed out, I'm not sure it's actually required. From what I can tell, folks were adopting it because of #212, but I can't reproduce that issue

Copy link

changeset-bot bot commented Aug 16, 2024

⚠️ No Changeset found

Latest commit: 6856848

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Aug 16, 2024

commit: 6856848

mdsvex

pnpm add https://pkg.pr.new/pngwn/MDsveX/mdsvex@636

pfm-parse

pnpm add https://pkg.pr.new/pngwn/MDsveX/pfm-parse@636

svast

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast@636

svast-stringify

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-stringify@636

svast-utils

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-utils@636

svelte-parse

pnpm add https://pkg.pr.new/pngwn/MDsveX/svelte-parse@636

Open in Stackblitz

Copy link
Owner

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benmccann!

@pngwn pngwn merged commit 175c256 into pngwn:main Aug 17, 2024
12 checks passed
@benmccann benmccann deleted the patch-2 branch September 7, 2024 16:14
@benmccann
Copy link
Contributor Author

@pngwn is there anything we need to do to get this deployed to the site? looks like the old version is still there: https://mdsvex.pngwn.io/docs#with-shiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants