Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semiring tests #68

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

AK2000
Copy link
Collaborator

@AK2000 AK2000 commented Oct 29, 2024

Added semiring operations to automatically assume same semantics as multiplication. This looks to fix the elementwise addition/subtraction as well but does not truly fix them. Requires #65 to be merged so that the new test case that causes elementwise addition to fail is also in this branch. After these fixes, the test results I see are:

Failed Tests (9):
  COMET :: compound_exps/CSR_Dense_chain_mult_matrix.ta
  COMET :: compound_exps/CSR_mult_spTranspose_CSR.ta
  COMET :: compound_exps/spTranspose_CSR_eltwise_CSR.ta
  COMET :: compound_exps/spTranspose_CSR_mult_CSR.ta
  COMET :: kernels/triangleCount_SandiaLL.ta
  COMET :: kernels/triangleCount_SandiaLL_wMasking.ta
  COMET :: ops/eltwise_mult_DCSRxDense_oDCSR.ta
  COMET :: ops/mult_spgemm_CSRxCSR_oCSR_wMasking.ta
  COMET :: opts/opt_dense_transpose.ta


Testing Time: 1.45s

Total Discovered Tests: 136
  Unsupported:  15 (11.03%)
  Passed     : 112 (82.35%)
  Failed     :   9 (6.62%)

@AK2000 AK2000 changed the base branch from master to Alok-indextree-rewrite October 29, 2024 00:30
@AK2000 AK2000 merged commit 2705351 into pnnl:Alok-indextree-rewrite Oct 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant