-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug/energy #30
Open
Firepanda415
wants to merge
35
commits into
main
Choose a base branch
from
debug/energy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Debug/energy #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric one in the future
…(uccsd.cpp and uccsdqis.cpp should gives the same results in the highest level of symmetries, i..e, symm 4 for uccsd, symm 2 for uccsdqis)
…CSD can be enabled with "--origin" flag. The symmetry in Matt's UCCSD was fixed in the previous commit. SInglet GSD is needs further changes
…oximation than UCCSD
…nd main.cpp command line argument, both defaults to xacc
Firepanda415
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
UCCSD
)vqe/main.cpp
andvqe/qflow.cpp
VERSION.txt
New Features
UCCSDmin
). It is the default ansatz nowSinglet_GSD
)Code Correctness
vqe/example_hamiltonians/README.md
for data comparison.Remaining Issues
follow_fixed_gradient()
invqe/include/vqe_state.hpp
usually converges with a bad result. There is no bug there. I think this is specifically for the effective Hamiltonian only used in QFlow. The main branch has the same code. I believe we can update it during the QFlow project in a new branch if necessary, as this is the debug branch, and its work has been done.LN_NEWUOA
as the optimizer and raises errors related to (solution) dimensions. There is no problem with another optimizer likeLN_COBYLA
orLD_LBFGS
. It is not really some problems in our code, I believe. The example code invqe/example_hamiltonians/README.md
should allow any new user to avoid this issue.DUCC
indexing scheme and I am not sure how to generate a Hamiltonian file to check. I don't think it is a problem since its index mapping code is isomorphic toXACC/Qiskit
code, which never had any bugs.