Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

249 new project prepopulation #261

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

lindsayJohnstonPnnl
Copy link
Collaborator

@lindsayJohnstonPnnl lindsayJohnstonPnnl commented Jan 9, 2025

We went back and forth a lot about the desired UI for this, hence all of the commits :D

NEW UI CREATED:

When user clicks New Project:

  1. Project Name and Installation Company are now both required fields:
    image

  2. They will see the New Project form and it will pre-populate the Installer Information with the data from the last project they edited or created
    image

  3. I also noticed this bug where the user could submit an invalid form:

Screen.Recording.2025-01-08.at.4.41.21.PM.mov
  • I fixed this bug in my branch, but I didn't spend a ton of time making it ideal. Perhaps we could revisit this UX?

SUGGESTIONS FOR NEXT STEPS:

  1. When the user chooses to edit an existing project, they see the same "New Project" form. This was existing behavior that I did not change, but it might be good to change that heading to "Editing Project" or something similar.

image

  1. Because there are quite a few differences between how the "new project" and "edit project" forms work, there is a lot of conditional logic switching things on and off. I might suggest creating an entirely different route (maybe /app/{id-number}/edit) and a separate EditProject component for editing an existing project. I think that this would make the code easier to read and work on in the future.

  2. Some other things I noticed in the UI:

  • Would be nice to have a "Home" button (could even hyperlink the "Quality Install Tool" header so that it directs to the root route.

  • This is nitpicky, but the Quality Install Tool Heading is not centered here:

image

  • Would be nice to have a "Back" button at the top of the New Project or Edit Project form. I found myself clicking the back button on the browser from this page and it doesn't work as I expected. Maybe we should change that too? I think it might be coming from the way we are navigating here with replace:true:

image

Screen.Recording.2025-01-08.at.4.33.38.PM.mov

…lating. There is a bug in editing a project.
…documents, sets lastModifiedProject, hides the dropdown if this is an existing project.
@lindsayJohnstonPnnl lindsayJohnstonPnnl marked this pull request as ready for review January 9, 2025 00:11
…if the tech name, company name and phone number were all filled out in the last projec and for the options in the drop down to only be available if all 3 of those fields were filled out.
…sed on unique company name. Drop down is being populated correctly. Form is being pre-populated correctly. Need to add the ability for user to choose option from dropdown.
…ly one that is required from Installer info. Added asterisks to a couple fields. Added an input error message for Installation company. Changed Installer Information verbiage.
@sudhacheran
Copy link
Collaborator

sudhacheran commented Jan 27, 2025

The changes looks great!

Is it possible to add a condition for displaying the dropdown to pre-populate the installer information as needed? Since the NewProject is now added as a component, providing an option to enable or disable this feature might be useful.

Thank you for the suggestions for improvement

Edit Feature: I hope we can change the page title to "Edit Project Information" when opening an existing project, as the component supports both the new and edit features. Could we rename the component accordingly?
Back Button: Adding a back button could be a useful feature. It wasn’t included earlier because the project ID is created when landing on the "Add Project Details" page. We could discuss this with the team.
Alignment Issue: Good catch on the alignment. We need to check if this issue occurs on all pages and update the alignment where necessary.

@lindsayJohnstonPnnl
Copy link
Collaborator Author

The changes looks great!

Is it possible to add a condition for displaying the dropdown to pre-populate the installer information as needed? Since the NewProject is now added as a component, providing an option to enable or disable this feature might be useful.

Thank you for the suggestions for improvement

Edit Feature: I hope we can change the page title to "Edit Project Information" when opening an existing project, as the component supports both the new and edit features. Could we rename the component accordingly? Back Button: Adding a back button could be a useful feature. It wasn’t included earlier because the project ID is created when landing on the "Add Project Details" page. We could discuss this with the team. Alignment Issue: Good catch on the alignment. We need to check if this issue occurs on all pages and update the alignment where necessary.

@sudhacheran want me to make tickets for these things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants