-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
249 new project prepopulation #261
base: main
Are you sure you want to change the base?
Conversation
…hange for the fields doesn't work.
…irects to the home page.
…st recent project modified.
…state and photo are not autofilling yet.
…ept email, state and photo.
…lating. There is a bug in editing a project.
…documents, sets lastModifiedProject, hides the dropdown if this is an existing project.
… with the last modified project data.
…sed on the Installer information. Not pretty but seems to be working.
…rmation doesn't show in the drop down.
…if the tech name, company name and phone number were all filled out in the last projec and for the options in the drop down to only be available if all 3 of those fields were filled out.
…sed on unique company name. Drop down is being populated correctly. Form is being pre-populated correctly. Need to add the ability for user to choose option from dropdown.
…ly one that is required from Installer info. Added asterisks to a couple fields. Added an input error message for Installation company. Changed Installer Information verbiage.
The changes looks great! Is it possible to add a condition for displaying the dropdown to pre-populate the installer information as needed? Since the NewProject is now added as a component, providing an option to enable or disable this feature might be useful. Thank you for the suggestions for improvement Edit Feature: I hope we can change the page title to "Edit Project Information" when opening an existing project, as the component supports both the new and edit features. Could we rename the component accordingly? |
@sudhacheran want me to make tickets for these things? |
We went back and forth a lot about the desired UI for this, hence all of the commits :D
NEW UI CREATED:
When user clicks New Project:
Project Name and Installation Company are now both required fields:

They will see the New Project form and it will pre-populate the Installer Information with the data from the last project they edited or created

I also noticed this bug where the user could submit an invalid form:
Screen.Recording.2025-01-08.at.4.41.21.PM.mov
SUGGESTIONS FOR NEXT STEPS:
Because there are quite a few differences between how the "new project" and "edit project" forms work, there is a lot of conditional logic switching things on and off. I might suggest creating an entirely different route (maybe /app/{id-number}/edit) and a separate EditProject component for editing an existing project. I think that this would make the code easier to read and work on in the future.
Some other things I noticed in the UI:
Would be nice to have a "Home" button (could even hyperlink the "Quality Install Tool" header so that it directs to the root route.
This is nitpicky, but the Quality Install Tool Heading is not centered here:
replace:true
:Screen.Recording.2025-01-08.at.4.33.38.PM.mov