RCT/YJ/is_chiller_performance_app_j function #1859
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set-checking-tool into RCT/YJ/is_chiller_perf_app_j_2022
JacksonJ-KC
reviewed
Nov 4, 2025
| EXPECTED_ENTERING_CONDENSER_WATER_TEMPS = [60.0, 72.5, 85.0, 97.5, 104.0] | ||
|
|
||
|
|
||
| def is_chiller_performance_app_j(chiller: dict) -> bool: |
There was a problem hiding this comment.
@yunjoonjung-PNNL updates have been made to the RDS for this ruleset function and to 22-42,43,44
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you. I'll take a look and make changes accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this function is merged, I'll revisit rules 22-42 and 22-43.