RS/YJ/Rule_12-5 (2022) #1863
Draft
RS/YJ/Rule_12-5 (2022) #1863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Dependency on #1846 |
weilixu
reviewed
Nov 4, 2025
Collaborator
weilixu
left a comment
weilixu
left a comment
There was a problem hiding this comment.
Left comments to address
| "$.buildings[*].building_segments[*].zones[*].spaces[*].miscellaneous_equipment[*]", | ||
| rmd_p, | ||
| ) | ||
| ][0], |
Collaborator
There was a problem hiding this comment.
Why there is [0] at the end of the list? Also, the sum here will just flatten this 2D array, instead of sum it into a value.
I think this schedule_eflh_p shall be a dictionary, in which the key is the schedule ID and the value is the sum of the hourly value?
| loads_included_p = ( | ||
| misc_equip_p["power"] > 0 * ureg("W") | ||
| and misc_equip_p["sensible_fraction"] > 0 | ||
| and misc_equip_p["latent_fraction"] > 0 |
Collaborator
There was a problem hiding this comment.
In RDS, it says: and (misc_equipment_p.sensible_fraction > 0 or misc_equipment_p.latent_fraction > 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this rule yet.