Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds command 'entra group user add'. #5759

Closed
wants to merge 1 commit into from
Closed

Adds command 'entra group user add'. #5759

wants to merge 1 commit into from

Conversation

milanholemans
Copy link
Contributor

@milanholemans milanholemans commented Jan 5, 2024 •
edited
Loading

Closes #5471

  • Added a util function to get the user ID by UPN (array variant). This is something we can use at multiple other places as well.
  • Added validation util for array of UPNs

This was referenced Jan 9, 2024
Closed
Closed
waldekmastykarz
waldekmastykarz requested changes Jan 20, 2024
View reviewed changes
Copy link
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Awesome use of batching! Let's do a few adjustments before we merge it

@waldekmastykarz waldekmastykarz self-assigned this Jan 20, 2024
@waldekmastykarz waldekmastykarz marked this pull request as draft January 20, 2024 14:45
@milanholemans milanholemans marked this pull request as ready for review January 22, 2024 22:45
waldekmastykarz
waldekmastykarz reviewed Feb 10, 2024
View reviewed changes
src/m365/entra/commands/group/group-user-add.ts

if (args.options.ids) {
const ids = args.options.ids.split(',').map(i => i.trim());
if (!validation.isValidGuidArray(ids)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this in a separate issue so that we don't need to iterate through the array twice

@waldekmastykarz
Copy link
Member

Merged manually. Thank you! 👏

@milanholemans milanholemans deleted the entra-group-user-add branch February 10, 2024 11:00
@milanholemans milanholemans mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldekmastykarz waldekmastykarz waldekmastykarz requested changes

Assignees

@waldekmastykarz waldekmastykarz

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: entra group user add
2 participants
@milanholemans @waldekmastykarz