Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more options to spo user remove. closes #5522 #5806

Closed
wants to merge 25 commits into from

Conversation

reshmee011
Copy link
Contributor

Closes #5522

@milanholemans
Copy link
Contributor

Thank you @reshmee011, we'll try to review it ASAP!

@reshmee011
Copy link
Contributor Author

@milanholemans , many thanks, not sure whether I have handled the additional options in the best possible way , it will good to have someone's else opinion.

@Adam-it Adam-it self-assigned this Feb 11, 2024
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reshmee011 awesome work 👏
Thank you for this PR. You rock 🚀
I added some minor comments trying to suggest the solution or approach. Please give them a check before we proceed with the merge 👍

@Adam-it Adam-it marked this pull request as draft February 11, 2024 23:09
@reshmee011
Copy link
Contributor Author

@Adam-it : Thanks for the awesome review, I learn a lot from the coding reviews. Hopefully I will finish reviewing all comments soon.

@Adam-it
Copy link
Member

Adam-it commented Feb 12, 2024

@Adam-it : Thanks for the awesome review, I learn a lot from the coding reviews. Hopefully I will finish reviewing all comments soon.

No rush. Once again thank you for sticking with us 👍🤙. Let me know if you need any kind of help 🙂

@reshmee011
Copy link
Contributor Author

@Adam-it : If I don't finish the review today, it will only over the weekend I might be able to work it as it is half term this week (school holidays for the girls) and my brother-in-law's wedding on Wednesday.

@reshmee011 reshmee011 marked this pull request as ready for review February 13, 2024 06:44
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reshmee011 Awesome work so far. Let's give it another round before we proceed 👍👏
You Rock 🤩😍

@Adam-it Adam-it marked this pull request as draft February 29, 2024 01:08
@Adam-it
Copy link
Member

Adam-it commented Feb 29, 2024

@reshmee011 I added a few more comments (mostly tiny details) 👍. Please double-check that GitHub tends to collapse comments so it's easy to overlook them and I suspect that is what happened also last time as I noticed 2 comments were not resolved (no problem with that👍)
image

As always let me know if you need any help or if something is not clear 🙂

@Adam-it
Copy link
Member

Adam-it commented Mar 8, 2024

@reshmee011 I rechecked your question with the CommandError and left the comment for it. Basically it was all ok and I failed to notice we are already hanling it ok. As for the progress I see we still have some unresolved comments? Do you need any help from my side on those?
Once again sorry for the hold up from my side 🙏

@reshmee011
Copy link
Contributor Author

@Adam-it : I fell victim to the collapsed comment sections failing to resolve all. I think I have handled them all now. Sorry about this, I know it can frustrating to repeat the same thing.
You are awesome and I have learned a lot from your comments and your demo during the community call. Don't worry about the delay, the most important is to get it right.

@reshmee011 reshmee011 marked this pull request as ready for review March 9, 2024 00:01
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👏👏👏
one small comment which I will sort out along the way 👍

@@ -14,38 +14,69 @@ m365 spo user remove [options]

```md definition-list
`-u, --webUrl <webUrl>`
: URL of the web to remove user
: URL of the web to remove user. Use either `id` or `loginName` or `email`, `userName`, `entraGroupId`, or `entraGroupName`, but not all.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: URL of the web to remove user. Use either `id` or `loginName` or `email`, `userName`, `entraGroupId`, or `entraGroupName`, but not all.
: URL of the web to remove user.

@Adam-it
Copy link
Member

Adam-it commented Mar 9, 2024

Ready to merge 🚀
I should resolve one small comment when merging

@Adam-it
Copy link
Member

Adam-it commented Mar 11, 2024

Merged manually 👍
Awesome work 👏

@Adam-it Adam-it closed this Mar 11, 2024
@reshmee011 reshmee011 deleted the sporemoveoptions branch May 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add more options to spo user remove
3 participants