Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds engage community user add. Closes #6293 #6388

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adds engage community user add. Closes #6293 #6388

wants to merge 3 commits into from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #6293

@MathijsVerbeeck MathijsVerbeeck linked an issue Sep 26, 2024 that may be closed by this pull request
New command: viva engage community user add #6293
Open
@MathijsVerbeeck MathijsVerbeeck added the pr-major PR for the next major release label Sep 26, 2024
@Adam-it Adam-it changed the base branch from v10 to main September 30, 2024 13:28
@MathijsVerbeeck MathijsVerbeeck force-pushed the add-viva-engage-community-user-add branch from fb971cd to b4b41b5 Compare October 2, 2024 08:56
@martinlingstuyl martinlingstuyl self-assigned this Oct 4, 2024
martinlingstuyl
martinlingstuyl requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MathijsVerbeeck, got some comments for you. ⚡

@martinlingstuyl martinlingstuyl mentioned this pull request Oct 4, 2024
Open
@martinlingstuyl martinlingstuyl marked this pull request as draft October 6, 2024 13:58
@martinlingstuyl
Copy link
Contributor

Hi @MathijsVerbeeck, do you have the time to conclude the work on these two viva PR's soon? I'm in the presupposition they need to be included in v10. So I'd hope to merge them sometime soon.

@Jwaegebaert
Copy link
Contributor

@MathijsVerbeeck, since you're using the same util, I’ve already applied the changes @martinlingstuyl recommended. You can check it out here: #6371.

@Jwaegebaert Jwaegebaert mentioned this pull request Oct 18, 2024
Closed
@martinlingstuyl
Copy link
Contributor

Whats the status here @MathijsVerbeeck? It's marked PR-major. But we'll need to do some work yet to include it.

@Adam-it Adam-it removed the pr-major PR for the next major release label Oct 30, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 30, 2024

I am removing the pr-major label from this PR as we agreed to proceed with this change the 'standard' way and the removal of the group commands as breaking change that will target v11

@MathijsVerbeeck MathijsVerbeeck force-pushed the add-viva-engage-community-user-add branch from b4b41b5 to 16f9208 Compare March 5, 2025 07:42
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review March 5, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jwaegebaert Jwaegebaert Jwaegebaert left review comments

@martinlingstuyl martinlingstuyl martinlingstuyl requested changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: viva engage community user add
4 participants
@MathijsVerbeeck @martinlingstuyl @Jwaegebaert @Adam-it