New command: spo site alert remove. Closes #6863 #6997
Conversation
|
Thanks @Saurabh7019! We'll try to review it ASAP. |
| webUrl: zod.alias('u', z.string()) | ||
| .refine(url => validation.isValidSharePointUrl(url) === true, url => ({ | ||
| message: `'${url}' is not a valid SharePoint URL.` | ||
| })), |
There was a problem hiding this comment.
The zod.alias should include the refine as well. Otherwise, the alias is not registered correctly and cannot be used.
| webUrl: zod.alias('u', z.string()) | |
| .refine(url => validation.isValidSharePointUrl(url) === true, url => ({ | |
| message: `'${url}' is not a valid SharePoint URL.` | |
| })), | |
| webUrl: zod.alias('u', z.string() | |
| .refine(url => validation.isValidSharePointUrl(url) === true, url => ({ | |
| message: `'${url}' is not a valid SharePoint URL.` | |
| }))), |
| } | ||
|
|
||
| public get description(): string { | ||
| return 'Removes an alert from a SharePoint site'; |
There was a problem hiding this comment.
| return 'Removes an alert from a SharePoint site'; | |
| return 'Removes an alert from a SharePoint list'; |
|
|
||
| # spo site alert remove | ||
|
|
||
| Removes an alert from a SharePoint site |
There was a problem hiding this comment.
| Removes an alert from a SharePoint site | |
| Removes an alert from a SharePoint list |
| await request.delete(requestOptions); | ||
| } | ||
| catch (err: any) { | ||
| this.handleRejectedPromise(err); |
There was a problem hiding this comment.
| this.handleRejectedPromise(err); | |
| this.handleRejectedODataJsonPromise(err); |
There was a problem hiding this comment.
sorry for the delay :)
handleRejectedPromise is showing cleaner error instead of raw xml.
with handleRejectedODataJsonPromise, I am getting below:
Error: <?xml version="1.0" encoding="utf-8"?><m:error xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata"><m:code>-2146232832, Microsoft.SharePoint.SPException</m:code><m:message xml:lang="en-US">The alert you are trying to access does not exist or has just been deleted. </m:message></m:error>
should I keep the current one?
| }); | ||
|
|
||
| it('prompts before removing the alert', async () => { | ||
| await command.action(logger, { options: commandOptionsSchema.parse({ webUrl: webUrl, id: alertId }) }); |
There was a problem hiding this comment.
The parsing of the options is not needed. Let's fix this for other tests as well.
| await command.action(logger, { options: commandOptionsSchema.parse({ webUrl: webUrl, id: alertId }) }); | |
| await command.action(logger, { options: { webUrl: webUrl, id: alertId } }); |
There was a problem hiding this comment.
Sure, I will fix it. I was asked to add it on another PR.
| }); | ||
|
|
||
| it('aborts removing the alert when prompt is not confirmed', async () => { | ||
| const deleteStub = sinon.stub(request, 'delete').resolves({}); |
There was a problem hiding this comment.
| const deleteStub = sinon.stub(request, 'delete').resolves({}); | |
| const deleteStub = sinon.stub(request, 'delete').resolves(); |
|
|
||
| it('correctly handles random API error', async () => { | ||
| sinon.stub(request, 'delete').rejects( | ||
| new Error('The alert you are trying to access does not exist or has just been deleted.') |
There was a problem hiding this comment.
This is not how a failing API call to SharePoint would look like. Instead, let's make it as realistic as possible with a read failing request body.
| : The ID of the alert. | ||
|
|
||
| `-f, --force` | ||
| : Don't prompt for confirmation |
There was a problem hiding this comment.
| : Don't prompt for confirmation | |
| : Don't prompt for confirmation. |
2 participants
Closes #6863