Fix 6941-Added minimal permissions for 'entra m365group recyclebin' commands #7002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binitem' commands
|
Thanks, we'll try to review it ASAP! |
MartinM85
requested changes
Oct 17, 2025
There was a problem hiding this comment.
Nice work @NishkalankBezawada 🚀
I have a couple of small comments, nothing major.
Comment on lines
+29
to
+31
| | Resource | Permissions | | ||
| |-----------------|-----------------------------| | ||
| | Microsoft Graph | Group.ReadWrite.All | |
There was a problem hiding this comment.
Please improve formatting
Suggested change
| | Resource | Permissions | | |
| |-----------------|-----------------------------| | |
| | Microsoft Graph | Group.ReadWrite.All | | |
| | Resource | Permissions | | |
| |-----------------|---------------------| | |
| | Microsoft Graph | Group.ReadWrite.All | |
Comment on lines
+34
to
+40
| <TabItem value="Application"> | ||
|
|
||
| | Resource | Permissions | | ||
| |-----------------|-----------------------------| | ||
| | Microsoft Graph | Group.Read.All | | ||
|
|
||
| </TabItem> |
There was a problem hiding this comment.
Let's remove the application permissions. I've checked the doc and the endpoint called by the command doesn't support application permissions.
Suggested change
| <TabItem value="Application"> | |
| | Resource | Permissions | | |
| |-----------------|-----------------------------| | |
| | Microsoft Graph | Group.Read.All | | |
| </TabItem> |
Comment on lines
+32
to
+34
| | Resource | Permissions | | ||
| |-----------------|-----------------------------| | ||
| | Microsoft Graph | Group.Read.All | |
There was a problem hiding this comment.
Please improve formatting
Suggested change
| | Resource | Permissions | | |
| |-----------------|-----------------------------| | |
| | Microsoft Graph | Group.Read.All | | |
| | Resource | Permissions | | |
| |-----------------|----------------| | |
| | Microsoft Graph | Group.Read.All | |
Comment on lines
+39
to
+41
| | Resource | Permissions | | ||
| |-----------------|-----------------------------| | ||
| | Microsoft Graph | Group.Read.All | |
There was a problem hiding this comment.
Please improve formatting
Suggested change
| | Resource | Permissions | | |
| |-----------------|-----------------------------| | |
| | Microsoft Graph | Group.Read.All | | |
| | Resource | Permissions | | |
| |-----------------|----------------| | |
| | Microsoft Graph | Group.Read.All | |
Comment on lines
+38
to
+40
| | Resource | Permissions | | ||
| |-----------------|-----------------------------| | ||
| | Microsoft Graph | Group.ReadWrite.All | |
There was a problem hiding this comment.
Please improve formatting
Suggested change
| | Resource | Permissions | | |
| |-----------------|-----------------------------| | |
| | Microsoft Graph | Group.ReadWrite.All | | |
| | Resource | Permissions | | |
| |-----------------|---------------------| | |
| | Microsoft Graph | Group.ReadWrite.All | |
Comment on lines
+35
to
+37
| | Resource | Permissions | | ||
| |-----------------|-----------------------------| | ||
| | Microsoft Graph | User.DeleteRestore.All | |
There was a problem hiding this comment.
Correct permission for restoring soft-deleted group is Group.ReadWrite.All
Suggested change
| | Resource | Permissions | | |
| |-----------------|-----------------------------| | |
| | Microsoft Graph | User.DeleteRestore.All | | |
| | Resource | Permissions | | |
| |-----------------|---------------------| | |
| | Microsoft Graph | Group.ReadWrite.All | |
Comment on lines
+42
to
+44
| | Resource | Permissions | | ||
| |-----------------|-----------------------------| | ||
| | Microsoft Graph | User.DeleteRestore.All | |
There was a problem hiding this comment.
Correct permission for restoring soft-deleted group is Group.ReadWrite.All
Suggested change
| | Resource | Permissions | | |
| |-----------------|-----------------------------| | |
| | Microsoft Graph | User.DeleteRestore.All | | |
| | Resource | Permissions | | |
| |-----------------|---------------------| | |
| | Microsoft Graph | Group.ReadWrite.All | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added minimal permissions for 'entra m365group recyclebin' commands
Added minimal permissions for 'entra m365group recyclebin' commands.
Screenshots
m365 entra m365group recyclebinitem listm365 entra m365group recyclebinitem restore --id 87casd23-4xxx-4as0-b23d-a1234561dbd8m365 entra m365group recyclebinitem clearm365 entra m365group recyclebinitem remove --id 87casd23-4xxx-4as0-b23d-a1234561dbd8Closes #6941
Thanks,
Nish