Migrates to Zod v4

[waldekmastykarz]

No description provided.

[MartinM85]

Quick review. Nothing major, but maybe I overlooked something.

[MartinM85]

General remark.
If the option is optional, I would expect that the type will be boolean | undefined, but in that case the return type is simple boolean. It's a little bit confusing for me.
Is it valid to define option like preview: z.boolean().default(false).optional()?

[waldekmastykarz]

This is a matter of preference/need, whether we want to distinguish between undefined and false or not. In some case we do, like for set commands where we want to be able to tell whether to change a property to disabled (false) or leave it unmodified (undefined). For other things, we might not care about the undefined state and consider it equal to false for which we specify a default on the boolean.

[MartinM85]

Could we add an example how to define flag option? I'm not sure if it's required to set default value to false or keep it only optional
flag: z.boolean().optional() vs flag: z.boolean().optional().default(false). I would prefer flag: z.boolean().optional(), but global option like the verbose is defined like flag: z.boolean().optional().default(false).

[waldekmastykarz]

See #7005 (comment)

[MartinM85]

Suggested change

	userId: z.string().refine(id => validation.isValidGuid(id), {
	userId: z.uuid().refine(id => validation.isValidGuid(id), {

[waldekmastykarz]

If we're using uuid(), then we don't need to add manual refinement on top. z.uuid() would suffice.

[waldekmastykarz]

Thanks for the feedback @MartinM85! Very keen eye!