Skip to content

Conversation

@nanddeepn
Copy link
Contributor

Added minimal permission for graph directoryextension commands. Closes #6979

Copilot AI review requested due to automatic review settings October 15, 2025 09:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Microsoft Graph permission documentation to the graph directoryextension command documentation files. This addresses issue #6979 by ensuring all directory extension commands have their required permissions clearly documented.

Key changes:

  • Added permissions section to all four directoryextension command documentation files
  • Used read permissions for get/list operations and read/write permissions for add/remove operations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
directoryextension-remove.mdx Added Tabs imports and permissions section with Directory.ReadWrite.All
directoryextension-list.mdx Added permissions section with Directory.Read.All
directoryextension-get.mdx Added permissions section with Directory.Read.All
directoryextension-add.mdx Added permissions section with Directory.ReadWrite.All

Copy link
Contributor

@MartinM85 MartinM85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nanddeepn, good work. I have one general remark, but it should be easy to fix it.

I think it is enough to mention only the least privileged permission(s) required to run the command. The Directory.Read.All and Directory.ReadWrite.All permissions are among the highest-privileged permissions.

The commands call the following Graph API endpoints:
graph directoryextension add - https://learn.microsoft.com/en-us/graph/api/application-post-extensionproperty?view=graph-rest-1.0&tabs=http#permissions
graph directoryextension list - https://learn.microsoft.com/en-us/graph/api/application-list-extensionproperty?view=graph-rest-1.0&tabs=http#permissions
graph directoryextension get - https://learn.microsoft.com/en-us/graph/api/extensionproperty-get?view=graph-rest-1.0&tabs=http#permissions
graph directoryextension remove - https://learn.microsoft.com/en-us/graph/api/extensionproperty-delete?view=graph-rest-1.0&tabs=http

The Graph API documentation contains the minimal permissions

@MartinM85 MartinM85 self-assigned this Oct 16, 2025
@MartinM85 MartinM85 marked this pull request as draft October 16, 2025 06:38
@nanddeepn nanddeepn marked this pull request as ready for review October 18, 2025 09:37
Copilot AI review requested due to automatic review settings October 18, 2025 09:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copy link
Contributor

@MartinM85 MartinM85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @nanddeepn 🚀
Approved. I will merge it later.

@MartinM85 MartinM85 added pr-merged hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 19, 2025
@MartinM85
Copy link
Contributor

Merged manually. Thank you @nanddeepn

@MartinM85 MartinM85 closed this Oct 19, 2025
@nanddeepn nanddeepn deleted the issue-6979 branch October 20, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimal permissions for 'graph directoryextension' commands

3 participants