-
Notifications
You must be signed in to change notification settings - Fork 367
Added minimal permission for 'graph directoryextension' commands. Closes #6979 #7006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds Microsoft Graph permission documentation to the graph directoryextension command documentation files. This addresses issue #6979 by ensuring all directory extension commands have their required permissions clearly documented.
Key changes:
- Added permissions section to all four directoryextension command documentation files
- Used read permissions for get/list operations and read/write permissions for add/remove operations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| directoryextension-remove.mdx | Added Tabs imports and permissions section with Directory.ReadWrite.All |
| directoryextension-list.mdx | Added permissions section with Directory.Read.All |
| directoryextension-get.mdx | Added permissions section with Directory.Read.All |
| directoryextension-add.mdx | Added permissions section with Directory.ReadWrite.All |
…ry extension commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nanddeepn, good work. I have one general remark, but it should be easy to fix it.
I think it is enough to mention only the least privileged permission(s) required to run the command. The Directory.Read.All and Directory.ReadWrite.All permissions are among the highest-privileged permissions.
The commands call the following Graph API endpoints:
graph directoryextension add - https://learn.microsoft.com/en-us/graph/api/application-post-extensionproperty?view=graph-rest-1.0&tabs=http#permissions
graph directoryextension list - https://learn.microsoft.com/en-us/graph/api/application-list-extensionproperty?view=graph-rest-1.0&tabs=http#permissions
graph directoryextension get - https://learn.microsoft.com/en-us/graph/api/extensionproperty-get?view=graph-rest-1.0&tabs=http#permissions
graph directoryextension remove - https://learn.microsoft.com/en-us/graph/api/extensionproperty-delete?view=graph-rest-1.0&tabs=http
The Graph API documentation contains the minimal permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @nanddeepn 🚀
Approved. I will merge it later.
|
Merged manually. Thank you @nanddeepn |
Added minimal permission for
graph directoryextensioncommands. Closes #6979