Skip to content

Conversation

@MathijsVerbeeck
Copy link
Contributor

Closes #6267

Copilot AI review requested due to automatic review settings October 16, 2025 06:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new SharePoint Online command spo site accessrequest setting set that allows users to configure access request settings for a specific site. The command supports disabling access requests, routing them to the site owner group, or routing them to a specific email address, with optional custom messaging.

Key Changes

  • Adds new command to configure SharePoint site access request settings
  • Implements comprehensive validation for mutually exclusive options
  • Includes extensive test coverage with 100% code coverage

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/m365/spo/commands/site/site-accessrequest-setting-set.ts Main command implementation with validation and API calls to SharePoint REST endpoints
src/m365/spo/commands/site/site-accessrequest-setting-set.spec.ts Comprehensive test suite covering validation scenarios and execution paths
src/m365/spo/commands.ts Adds command constant for registration
docs/src/config/sidebars.ts Updates documentation sidebar navigation
docs/docs/cmd/spo/site/site-accessrequest-setting-set.mdx Command documentation with usage examples and permissions
.devproxy/api-specs/sharepoint.yaml Adds API specifications for the SharePoint REST endpoints used

await request.post(requestUseDefault);

if (message !== undefined) {

Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the empty line between the condition and the verbose logging block to improve code readability and maintain consistency with the rest of the codebase.

Suggested change

Copilot uses AI. Check for mistakes.
Comment on lines +126 to +127


Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the trailing empty lines at the end of the file to maintain consistency with project formatting standards.

Suggested change

Copilot uses AI. Check for mistakes.
Comment on lines +319 to +320


Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the trailing empty lines at the end of the file to maintain consistency with project formatting standards.

Suggested change

Copilot uses AI. Check for mistakes.
Comment on lines +76 to +77


Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the trailing empty lines at the end of the file to maintain consistency with project formatting standards.

Suggested change

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 16, 2025 06:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comment on lines +319 to +320


Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the trailing blank lines at the end of the file.

Suggested change

Copilot uses AI. Check for mistakes.
Comment on lines +126 to +127


Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the trailing blank lines at the end of the file.

Suggested change

Copilot uses AI. Check for mistakes.
Comment on lines +78 to +79


Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the trailing blank lines at the end of the file.

Suggested change

Copilot uses AI. Check for mistakes.
@martinlingstuyl martinlingstuyl added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accept for hacktoberfest, will merge later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New command: spo site accessrequest setting set

2 participants