Merge pull request #601 from pnp/dev

3.16.0
pnp · Feb 6, 2024 · 538af10 · 538af10
2 parents e68db52 + 2236193
commit 538af10
Show file tree

Hide file tree

Showing 9 changed files with 35 additions and 7 deletions.
diff --git a/CHANGELOG.json b/CHANGELOG.json
@@ -4,10 +4,17 @@
       "version": "3.16.0",
       "changes": {
         "new": [],
-        "enhancements": [],
-        "fixes": []
+        "enhancements": [
+          "`PropertyFieldSitePicker`: disabled property not implemented in UI [#577](https://github.com/pnp/sp-dev-fx-property-controls/issues/577)"
+        ],
+        "fixes": [
+          "`PropertyFieldMonacoEditor` and `PropertyFieldCodeEditor`: fix text selection in code editor [#590](https://github.com/pnp/sp-dev-fx-property-controls/issues/590)"
+        ]
       },
-      "contributions": []
+      "contributions": [
+        "[Luna Heyman](https://github.com/toodeluna)",
+        "[srpmtt](https://github.com/srpmtt)"
+      ]
     },
     {
       "version": "3.15.1",

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,14 @@
 
 ## 3.16.0
 
+### Fixes
+
+- `PropertyFieldMonacoEditor` and `PropertyFieldCodeEditor`: fix text selection in code editor [#590](https://github.com/pnp/sp-dev-fx-property-controls/issues/590)
+
+### Contributors
+
+Special thanks to our contributor: [Luna Heyman](https://github.com/toodeluna).
+
 ## 3.15.1
 
 ### Fixes

diff --git a/docs/documentation/docs/about/release-notes.md b/docs/documentation/docs/about/release-notes.md
@@ -2,6 +2,14 @@
 
 ## 3.16.0
 
+### Fixes
+
+- `PropertyFieldMonacoEditor` and `PropertyFieldCodeEditor`: fix text selection in code editor [#590](https://github.com/pnp/sp-dev-fx-property-controls/issues/590)
+
+### Contributors
+
+Special thanks to our contributor: [Luna Heyman](https://github.com/toodeluna).
+
 ## 3.15.1
 
 ### Fixes

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@pnp/spfx-property-controls",
   "description": "Reusable property pane controls for SharePoint Framework solutions",
-  "version": "3.15.1",
+  "version": "3.16.0",
   "engines": {
     "node": ">=16.13.0 <17.0.0 || >=18.17.1 <19.0.0"
   },

diff --git a/src/common/telemetry/version.ts b/src/common/telemetry/version.ts
@@ -1 +1 @@
-export const version: string = "3.15.1";
+export const version: string = "3.16.0";
diff --git a/src/propertyFields/codeEditor/PropertyFieldCodeEditorHost.tsx b/src/propertyFields/codeEditor/PropertyFieldCodeEditorHost.tsx
@@ -216,6 +216,7 @@ export default class PropertyFieldCodeEditorHost extends React.Component<IProper
               boxSizing: 'border-box'
             }
           }}
+          layerProps={{ eventBubblingEnabled: true }}
           onRenderFooterContent={() => (
             <div className={styles.actions}>
               <div className="ms-Grid" dir="ltr">

diff --git a/src/propertyFields/monacoEditor/PropertyFieldMonacoEditorHost.tsx b/src/propertyFields/monacoEditor/PropertyFieldMonacoEditorHost.tsx
@@ -103,7 +103,9 @@ export default class PropertyFieldMonacoEditorHost extends React.Component<
           }}
           headerText={strings.MonacoEditorPanelTitle}
           onRenderFooterContent={this.onRenderFooterContent}
-          isFooterAtBottom={true}>
+          isFooterAtBottom={true}
+          layerProps={{ eventBubblingEnabled: true }}
+        >
           <div className={this.controlClasses.headerTitle}>
             <MonacoEditor {...this.props} onValueChange={ this._onValueChange}/>
           </div>

diff --git a/src/propertyFields/sitePicker/PropertyFieldSitePickerHost.tsx b/src/propertyFields/sitePicker/PropertyFieldSitePickerHost.tsx
@@ -90,6 +90,7 @@ export default class PropertyFieldSitePickerHost extends React.Component<IProper
       <div>
         {this.props.label && <Label>{this.props.label}</Label>}
         <SearchBox
+          disabled={this.props.disabled}
           placeholder={strings.SitePickerSearchBoxPlaceholder}
           onChanged={this.async.debounce(this.onSearchFieldChange, this.props.deferredValidationTime)}
         />

diff --git a/src/webparts/propertyControlsTest/PropertyControlsTestWebPart.ts b/src/webparts/propertyControlsTest/PropertyControlsTestWebPart.ts
@@ -775,7 +775,8 @@ export default class PropertyControlsTestWebPart extends BaseClientSideWebPart<I
                   onPropertyChange: this.onPropertyPaneFieldChanged,
                   properties: this.properties,
                   key: 'sitesFieldId',
-                  trimDuplicates: true
+                  trimDuplicates: true,
+                  disabled: false
                 }),
                 PropertyFieldTeamPicker('teams', {
                   key: 'teamsPicker',
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export const version: string = "3.15.1";
		export const version: string = "3.16.0";