Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-directory to SPFx 1.20.0 #5284

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

Sandeep-FED
Copy link
Contributor

@Sandeep-FED Sandeep-FED commented Oct 5, 2024

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ), make notes next to any that haven't been addressed.

  • Bug fix/update
  • New sample
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

This is an upgrade PR of react-directory for hacktoberfest.

Node version used:
18.18.2

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@Adam-it Adam-it self-assigned this Oct 5, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 5, 2024

Thank you for opening a PR to our samples repo and helping us upgrade our project 👍
We will try to review this PR ASAP

@hugoabernier hugoabernier merged commit de20030 into pnp:main Oct 12, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

Many thanks @Sandeep-FED for your update! Always appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants