Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SPFx 1.20.0 #5327

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Upgrade to SPFx 1.20.0 #5327

merged 2 commits into from
Nov 9, 2024

Conversation

ferrarirosso
Copy link

What's in this Pull Request?

  • Upgrade to SPFx 1.20
  • Removed handlebar-helpers package (last update 7 years ago) and replace most helpers with lodash or js native functions.
  • Fixes bug when using custom template, webpart went in a render loop and tab freezes

Node Version

Node version used:
v18.20.4

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

Fixes bug when using custom template, webpart went in a render loop and tab freezes
@Adam-it Adam-it self-assigned this Nov 5, 2024
@hugoabernier hugoabernier merged commit fcee711 into pnp:main Nov 9, 2024
3 checks passed
@hugoabernier
Copy link
Collaborator

Thanks @ferrarirosso for your update! Always appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@ferrarirosso ferrarirosso deleted the issue-5254 branch November 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade RSS Reader web part to latest version of SPFx - Refresh Rangers Hacktoberfest Event
3 participants