Adds SVG to Json for SharePoint List Web Part #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Fixes size issue of svg
This reverts commit b7247ef.
|
Hello @LuiseFreese , it was nice to see your demo and it's a delight to process this PR! Your PR seems to include another web part (Bluesky?). Can you remove the second web part from the PR and submit that one as a separate PR? If you need help to do so, I can process the PR and remove the second sample, and we'll process a separate PR for the Bluesky web part when you're ready.
Let me know how you wish to proceed and we'll make it happen! |
|
Hey @hugoabernier I removed the bluesky sample from this PR. Thank you and let me know if this sample needs further improvement. |
hugoabernier
approved these changes
Nov 18, 2024
|
Hey @LuiseFreese, it looks like you re-added the Bluesky sample to the PR. Can you move it to a separate branch so I can process the sample? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Adds new sample that can Read SVGs from a specified library on a specified Site (property Pane), allows users to preview it and converts it into a format a SharePoint List's column will accept. Works with either convert & copy to clipboard (for further code manipulation) or can be directly applied to a Site, List, column of the users liking.
Node Version
18.20.4
Node version used:
Checklist
README.mdfile's Version history. For new samples, created a newREADME.mdfile matching this templateREADME.mdhas at least one static high-resolution screenshot (i.e. not a GIF) located in theassetsfolder.README.mdcontains complete setup instructions, including pre-requisites and permissions required.nvmrcfile indicating the version of Node.jsSubmitter Guidance (DELETE AFTER READING)