-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React webpart to manage bookmarks #5386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudeepghatak awesome work 👏 and sorry for the hold up 🙏
I managed to build and run the sample locally
I left a few minor comments I will try to fixup when merging
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not update any file outside of the sample folder.
Lets revet this change
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not update any file outside of the sample folder.
Lets revet this change
samples/react-sp-bookmarks/README.md
Outdated
|
||
**THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.** | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image at the end of the readme template is also needed here. We call it a visitor stats image and you may read about it in the contribution guide. It is needed for telemetry reasons. Lets add it
samples/react-sp-bookmarks/README.md
Outdated
@@ -0,0 +1,120 @@ | |||
# Using React Accordion plugin with SPFx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the wrong title
@sudeepghatak unfortunately I cannot perform the fixup for you as your commits are wrongly made directly to the main brand of your forked repo. Please try to move your changes to a separate branch (you may use the git cherry-pick) command to do that, and close this PR and open a new one. Along the way you may also apply the review comments I left in this PR. If you encounter any trouble along the way please do not hesitate to contact me and we may work it out together 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to move current changes to a separate dev branch different then main
before we proceed
Thanks @sudeepghatak for your sample! Always appreciated! We'd love to have your sample featured in one of our future community calls. If haven't done so yet, and you'd be interested on showing this great sample in a public community call, please fill in following form and we'll get you scheduled - aka.ms/community/request/demo Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
What's in this Pull Request?
The 'Bookmarks Manager' web part allows users to manage and organize bookmarks in a SharePoint list. Users can add, edit, and delete bookmarks, which are displayed in a grid layout. The web part supports both light and dark themes and integrates seamlessly with SharePoint.
Node Version
Node version used: 18.20.6
Checklist
README.md
file's Version history. For new samples, created a newREADME.md
file matching this templateREADME.md
has at least one static high-resolution screenshot (i.e. not a GIF) located in theassets
folder.README.md
contains complete setup instructions, including pre-requisites and permissions required.nvmrc
file indicating the version of Node.js