refactor tenant wide extensions for app catalog toggle #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-it
requested changes
Feb 16, 2025
There was a problem hiding this comment.
@ervingayle Looks like we are on the right track 👍👏 You Rock 🤩.
I left a few comments and I noticed we overlooked updating the site level app catalogs as well based on the setting
package.json
Outdated
| @@ -190,10 +190,10 @@ | |||
| "description": "Show the service health incidents in the account view." | |||
| }, | |||
| "spfx-toolkit.showTenantWideExtensions": { | |||
There was a problem hiding this comment.
it would be best if we also modify the setting identifier name from showTenantWideExtensions to showAppsInAppCatalogs
There was a problem hiding this comment.
Hi @Adam-it . Thanks for your feedback. For some reason I thought you did not want to rename the setting. I made the change.
Co-authored-by: Adam Wójcik <[email protected]>
Co-authored-by: Adam Wójcik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Aim
This PR refactors the tenant wide extensions logic to control the display of the app catalogs and the expansion of those if the setting is enabled
📷 Result
✅ What was done
🔗 Related issue
Closes: #325