Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multiselect): implementa as definições do AnimaliaDS #1850

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat(multiselect): implementa as definições do AnimaliaDS #1850

merged 1 commit into from
Oct 31, 2023

Conversation

anliben
Copy link
Contributor

@anliben anliben commented Oct 18, 2023 •
edited by rafaellmarques
Loading

multiselect

DTHFUI-7684

PR Checklist [Revisor]

  • Padrão de Commit (Coeso, de acordo com o que está sendo realizado)
  • Código (Boas práticas, nome de variavéis/métodos, etc.)
  • Testes unitários (Cobre a situação implementada e coverage está mantido)
  • Documentação (Clara, objetiva e com exemplos caso necessário)
  • Samples (A implementação possui exemplo no Labs/Caso de uso)
  • Rodado em navegadores suportados (Chrome, FireFox, Edge)

Qual o comportamento atual?
Caixa do multiselect não segue diretivas do animaliaDS

Qual o novo comportamento?
Caixa do multiselect não segue diretivas do animaliaDS

Simulação
Portal, App
app.zip
Style
Theme-totvs: totvs/po-theme-totvs#263

Customização de tokens:

@import url('https://fonts.googleapis.com/css2?family=Alumni+Sans+Collegiate+One&display=swap');
po-multiselect {
    --font-family: 'Alumni Sans Collegiate One', sans-serif;
    --font-size: var(--font-size-default);
    --text-color-placeholder: var(--color-action-disabled);
    --color: var(--color-neutral);
    --background: var(--color-neutral-light-98);
  
    --color-hover: var(--color-action-hover);
    --background-hover: var(--color-brand-01-lightest);
  
    --color-focused: var(--color-secondary);
    --outline-color-focused: var(--color-outline-focused);
  
    --color-disabled: var(--color-action-disabled);
    --background-disabled: var(--color-neutral-light-80);
  
    --color-error: var(--color-danger);
  }

@anliben anliben force-pushed the multiselect/DTHFUI-7684 branch 3 times, most recently from 053ac00 to f08dfad Compare October 20, 2023 16:57
felipepetuco
felipepetuco previously approved these changes Oct 20, 2023
View reviewed changes
@anliben anliben self-assigned this Oct 20, 2023
@anliben anliben added enhancement New feature or request hacktoberfest labels Oct 20, 2023
jnrpalma
jnrpalma previously approved these changes Oct 20, 2023
View reviewed changes
@anliben anliben dismissed stale reviews from jnrpalma and felipepetuco via 4ab8a0e October 24, 2023 19:55
@anliben anliben force-pushed the multiselect/DTHFUI-7684 branch from fdd4e61 to 4756a71 Compare October 26, 2023 19:49
@CSimoesJr CSimoesJr force-pushed the multiselect/DTHFUI-7684 branch from 776d39d to 64da6bb Compare October 26, 2023 20:36
@anliben anliben force-pushed the multiselect/DTHFUI-7684 branch from cf014a3 to b44215f Compare October 27, 2023 18:56
@CSimoesJr CSimoesJr force-pushed the multiselect/DTHFUI-7684 branch 3 times, most recently from f8add33 to 7273710 Compare October 27, 2023 20:51
@anliben anliben force-pushed the multiselect/DTHFUI-7684 branch 2 times, most recently from 13b016a to 1bcffae Compare October 30, 2023 16:01
@CSimoesJr CSimoesJr force-pushed the multiselect/DTHFUI-7684 branch 2 times, most recently from d08dd77 to 8a8e76c Compare October 30, 2023 17:37
@anliben anliben force-pushed the multiselect/DTHFUI-7684 branch from 98b7179 to 65edfcb Compare October 30, 2023 17:52
@CSimoesJr CSimoesJr force-pushed the multiselect/DTHFUI-7684 branch from 65edfcb to bbf700a Compare October 30, 2023 17:52
jcorrea97
jcorrea97 previously approved these changes Oct 30, 2023
View reviewed changes
felipepetuco
felipepetuco previously approved these changes Oct 30, 2023
View reviewed changes
@CSimoesJr CSimoesJr dismissed stale reviews from felipepetuco and jcorrea97 via e668550 October 31, 2023 17:41
@CSimoesJr CSimoesJr force-pushed the multiselect/DTHFUI-7684 branch from bbf700a to e668550 Compare October 31, 2023 17:41
felipepetuco
felipepetuco previously approved these changes Oct 31, 2023
View reviewed changes
@anliben @CSimoesJr
feat(multiselect): implementa as definições do AnimaliaDS
eb9ba7e 
Implementar as definições do handoff do multiselect no PoMultiselect.
Implementa propriedade literals na tag.
Implementa tooltip na tag removable.

Fixes DTHFUI-7684
@CSimoesJr CSimoesJr force-pushed the multiselect/DTHFUI-7684 branch from e668550 to eb9ba7e Compare October 31, 2023 19:33
@anliben anliben added the hacktoberfest-accepted Aceito para a hacktoberfest label Oct 31, 2023
@rafaellmarques rafaellmarques merged commit f31c075 into master Oct 31, 2023
7 checks passed
@rafaellmarques rafaellmarques deleted the multiselect/DTHFUI-7684 branch October 31, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipepetuco felipepetuco felipepetuco approved these changes

@jcorrea97 jcorrea97 jcorrea97 approved these changes

@rafaellmarques rafaellmarques rafaellmarques approved these changes

@jnrpalma jnrpalma jnrpalma left review comments

Assignees

@anliben anliben

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted Aceito para a hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anliben @rafaellmarques @jnrpalma @jcorrea97 @felipepetuco