Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing when function ABI is missing the outputs field #163

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

fedor-ivn
Copy link
Contributor

Closes #162.

@vbaranov vbaranov requested a review from ayrat555 March 7, 2024 09:20
Copy link
Collaborator

@ayrat555 ayrat555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. one small comment

} <-
item
# Workaround for missing "outputs" field.
# This is a fix for https://github.com/poanetwork/ex_abi/issues/162
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's write a full description here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, please check the new commit

@ayrat555 ayrat555 mentioned this pull request Mar 12, 2024
@fedor-ivn fedor-ivn requested a review from ayrat555 March 12, 2024 12:21
@ayrat555 ayrat555 merged commit 67eb2b9 into poanetwork:master Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABI.parse_specification ignores function objects without outputs field
2 participants