HMS-2151 fix: make it possible to accept defaults #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default "title" field comes from the domain record (i.e. whatever ipa-hcc defaults it to). But the wizard does not enable "Next" on the Service Details page until `onChangeTitle` fires. In other words, the user *must* change the value before they can proceed. It should be possible to accept the default. Extract "data is OK to proceed" behaviour to a new function `onUserInputChange`. Call this function from `onChangeTitle`, and *also* from `onVerify` when the domain data is first received. As a result, the Next button on the Service Details page should be enabled immediately, allowing the user to accept the defaults.
frasertweedale
force-pushed
the
wizard-accept-defaults
branch
from
afdfed0
to
ce1b576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default "title" field comes from the domain record (i.e. whatever ipa-hcc defaults it to). But the wizard does not enable "Next" on the Service Details page until
onChangeTitlefires. In other words, the user must change the value before they can proceed.It should be possible to accept the default. Extract "data is OK to proceed" behaviour to a new function
onUserInputChange. Call this function fromonChangeTitle, and also fromonVerifywhen the domain data is first received.As a result, the Next button on the Service Details page should be enabled immediately, allowing the user to accept the defaults.