Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HMS-2992): add cancel confirmation modal #46

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

avisiedo
Copy link
Contributor

@avisiedo avisiedo commented Apr 18, 2024

Add a confirmation modal dialog when we cancel the domain registration wizard.

When the action is confirmed, it tries to delete the domain if we have an id and the resource exists. Then the modal dialog is dismissed and navigate to the default view.

When the action is not confirmed, it just close the modal dialog.

image

@avisiedo avisiedo self-assigned this Apr 18, 2024
@avisiedo avisiedo force-pushed the hms-2992-confirm-cancel branch from 9f3df3b to 0502f05 Compare April 18, 2024 09:16
Copy link
Contributor

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks to work well except the text of the dialog.

Added also some Qs.

src/Routes/WizardPage/WizardPage.tsx Outdated Show resolved Hide resolved
src/Routes/WizardPage/WizardPage.tsx Outdated Show resolved Hide resolved
src/Routes/WizardPage/WizardPage.tsx Outdated Show resolved Hide resolved
During the domain registration wizard, when the
user click on cancel button, now a confirmation
modal dialog is showed up.

When the action is confirmed, a delete operation is
launched on the API; afterward the modal dialog is
closed and go to the main view.

When the action is not confirmed, the modal dialog
is closed with no additional action.

Signed-off-by: Alejandro Visiedo <[email protected]>
@avisiedo avisiedo force-pushed the hms-2992-confirm-cancel branch from 0502f05 to 84ccea3 Compare April 24, 2024 17:29
Copy link
Contributor

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is stilla new linter warning. But I that can be fixed separately with other warnings.

@avisiedo avisiedo merged commit 1220cdb into podengo-project:main Apr 25, 2024
1 check passed
@avisiedo avisiedo deleted the hms-2992-confirm-cancel branch April 25, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants