Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(HMS-4082): fail eslint on warnings #61

Merged
merged 1 commit into from
May 14, 2024

Conversation

pvoborni
Copy link
Contributor

To prevent introduction of new TypeScript lint warnings in the codebase.

@pvoborni
Copy link
Contributor Author

The initial CI failure ( https://github.com/podengo-project/idmsvc-frontend/actions/runs/9060131017/job/24889208169?pr=61 ) validates that this PR works.

The failure will be fixed when #60 is merged and this is rebased on top of it.

To prevent introduction of new TypeScript lint warnings in the codebase.

Signed-off-by: Petr Vobornik <[email protected]>
@avisiedo avisiedo self-requested a review May 14, 2024 10:29
Copy link
Contributor

@avisiedo avisiedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change 👍

I have checked it locally by make lint, and pipeline is green.

LGTM

@avisiedo avisiedo merged commit 79653b6 into podengo-project:main May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants