refactor(HMS-4080) replace PF5 deprecated components with new variants #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
PatternFly 5 deprecated dropdown list and replaced it with a newer variant. Signed-off-by: Petr Vobornik <[email protected]>
This component is not used anywhere. It is using Dropdown component deprecated by PatternFly 5. It needs almost full rewrite thus it is easier to delete it. Could be implemented in newer way when it is needed. Signed-off-by: Petr Vobornik <[email protected]>
PatternFly 5 has new implementation of Wizard component. This commit is using it instead of the old one so that the UI doesn't use deprecated components. Signed-off-by: Petr Vobornik <[email protected]>
|
Please don't merge this before the rollup demo :) |
avisiedo
approved these changes
May 20, 2024
There was a problem hiding this comment.
Excellent change!
I only have a concern about keeping or not the filtering field on the server details.
I have played with the changes locally, and everything worked well.
I have checked in ephemeral environment a basic cycle and interact with the different behavior of the UI and the changes on the PR worked successfully.
LGTM
@pvoborni the concern in the PR can be addressed in a separate PR if a change were necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces:
DropdownonDetailsPageWizardFilterFieldas it uses deprecatedDropdownbut it is not used.Rebased on top of #62