Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: launch with no prompts from make rule #80

Merged
merged 1 commit into from
Jun 20, 2024
Merged

build: launch with no prompts from make rule #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"lint:prettier": "prettier --check src",
"patch:hosts": "fec patch-etc-hosts",
"start": "HOT=true fec dev",
"start-beta": "HOT=true fec dev --clouddotEnv=stage --uiEnv=beta",
"test": "TZ=UTC jest --verbose --no-cache",
"test-watch": "TZ=UTC jest --watch",
"postinstall": "ts-patch install && rimraf .cache",
Expand Down
10 changes: 8 additions & 2 deletions scripts/mk/crc-frontend.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,15 @@ prettier: $(NODE_BIN)/prettier ## Make code prettier
test: $(NODE_BIN)/jest ## Execute unit tests
npm run test

$(eval NPM_RUN_START:=npm run start)
ifneq (,$(findstring $(CLOUDDOT_ENV),stage prod))
ifneq (,$(findstring $(UI_ENV),beta stable))
$(eval NPM_RUN_START:=npm run start -- --clouddotEnv="$(CLOUDDOT_ENV)" --uiEnv="$(UI_ENV)")
endif
endif
.PHONY: run
run:$(NODE_BIN)/fec ## Execute frontend
npm run start
run: $(NODE_BIN)/fec ## Execute frontend
$(NPM_RUN_START)

.PHONY: generate-api
generate-api: $(NODE_BIN)/openapi-generator-cli $(NODE_BIN)/prettier $(PUBLIC_OPENAPI) ## Generate the API client from openapi specification
Expand Down
3 changes: 3 additions & 0 deletions scripts/mk/variables.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@

APP_NAME := idmsvc

# Determine the default run environment
CLOUDDOT_ENV ?= stage
UI_ENV ?= beta

Loading