Backend support for the campaigns' expenses #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to upload files for each expense.
…r of the campaign or by the admin.
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
…on't need blocked amount logic currently.
dimitur2204
requested changes
Mar 16, 2023
github-actions
bot
removed
the
run tests
github-actions
bot
removed
the
run tests
igoychev
requested changes
Mar 25, 2023
github-actions
bot
removed
the
run tests
igoychev
reviewed
Mar 25, 2023
1. remove can-edit endoint - we can do this in the frontent with the current endpoints. 2. move list expenses to the campaign controller. 3. Fetch the uploader it from the logged user. It used to be hardcoded.
…her the organizer or an admin.
github-actions
bot
removed
the
run tests
igoychev
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow the user to add, fetch and delete campaign expenses.
Only the organizer (or admin) should be able to edit them.
Only an admin can approve an expense.
But the general public should be able to see any approved expenses.
The expense files are uploaded to AWS.
Environment
We need to create one new AWS bucket: 'expenses-files'