Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft version of cookie consent feature #1615

Conversation

dzhaniivanov
Copy link
Contributor

@dzhaniivanov dzhaniivanov commented Oct 10, 2023

We need to implement cookies for GA in order to not violate the GDPR.
#1590

Screenshot 2023-10-10 092511
Screenshot 2023-10-10 092448

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

❌ Not all tests have run for this PR. Please add the run tests label to trigger them.

@dzhaniivanov dzhaniivanov marked this pull request as draft October 10, 2023 06:26
return (
<CookieConsent
enableDeclineButton
// cookieName="PodkrepiConsent"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we going to need the cookie name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no just because the react-cookie-consent library doesn't track it with different name
Screenshot 2023-10-16 171451
Screenshot 2023-10-16 171739

this is the edited version - @igoychev , please review

@dzhaniivanov dzhaniivanov marked this pull request as ready for review October 16, 2023 16:15
@ani-kalpachka
Copy link
Member

Great addition! 🚀
I would remove the styles for the Cookie Consent component from the global styles and place them in a separate file or in the component file. By doing this the '!important' properties are not going to be needed too.

@ani-kalpachka
Copy link
Member

Updated changes are added here: #1634
This PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants