Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect restriction in withdrawls edit form #1709

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Incorrect restriction in withdrawls edit form #1709

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
552758d
Remove unused translations, add EN translations for bank transactions…
ani-kalpachka Jan 15, 2024
64725c5
Update email address on FAQ (#1705)
ani-kalpachka Jan 16, 2024
18b7e92
Update translations (#1706)
ani-kalpachka Jan 17, 2024
40fbd0c
Update translations (#1707)
ani-kalpachka Jan 19, 2024
8dd46dc
components/commmon: Gallery component improvements (#1708)
sashko9807 Jan 20, 2024
d0aed1d
Merge branch 'podkrepi-bg:master' into mmaster
slavcho Jan 22, 2024
9ee3c58
The amount of the withdrawals can be a decimal number. It should not …
slavcho Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/admin/withdrawals/EditForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const validationSchema: yup.SchemaOf<WithdrawalData> = yup
.defined()
.shape({
status: yup.string().trim().min(1).max(10).required(),
amount: yup.number().positive().integer().required(),
amount: yup.number().positive().required(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it is an issue considering the amount field can't be edited in EditForm, but maybe for consistency reason we should at least have the number().positive(), rules for amount validation.

reason: yup.string().trim().min(1).max(300).required(),
currency: yup.string().oneOf(Object.values(Currency)).required(),
sourceVaultId: yup.string().uuid().required(),
Expand Down
Loading