Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace react-i18next imports with next-i18next #1844

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

sashko9807
Copy link
Member

next-i18next offers SSR support. Although we don't need it specifically for every component it is better to prefer over react-i18next, in order to maintain consistency.

  • Added eslint rule to prevent react-i18next imports

next-i18n offers SSR support. Although we don't need it specifically for every component it is better to prefer it in order to maintain consistency
Copy link

github-actions bot commented Jun 6, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Jun 6, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jun 6, 2024
@ani-kalpachka ani-kalpachka merged commit 37fbf5b into podkrepi-bg:master Jun 6, 2024
11 of 12 checks passed
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this pull request Jun 19, 2024
…g#1844)

* refactor: Replace react-i18next imports with next-i18next
next-i18n offers SSR support. Although we don't need it specifically for every component it is better to prefer it in order to maintain consistency

* eslint: Add rule to prevent react-i18next imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants