Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add admin campaign applications #1882

Merged

Conversation

gparlakov
Copy link
Contributor

  • add a login fixture
  • add a test that verifies the current admin list of campaign applications

Motivation and context

Authentication of a user in e2e tests context
Verification of Admin Campaign Application pages

Testing

run the e2e tests

Environment

New environment variables:

  • PODKREPI_EMAIL: email for user auth
  • PODKREPI_PASSWORD: password for user auth

Copy link

github-actions bot commented Jul 10, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

Copy link

gitguardian bot commented Jul 10, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gparlakov gparlakov force-pushed the admin-campaign-application-e2e-test branch 2 times, most recently from 6193054 to 5b66bea Compare July 10, 2024 15:20
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Jul 15, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 15, 2024
@sashko9807
Copy link
Member

E2E job seems to fail.
Though im not sure if any auth-based e2e test would ever pass, as we don't have a job to setup keycloak, which is needed for auth(or at least I don't see one).

@gparlakov
Copy link
Contributor Author

gparlakov commented Jul 16, 2024 via email

@gparlakov
Copy link
Contributor Author

gparlakov commented Jul 16, 2024

E2E job seems to fail.

I can't seem to find the run of those (neither unit-tests.yaml or playwright.yaml-s workflow logs show a failed run) @sashko9807 was that run locally or via the actions?

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Jul 16, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 16, 2024
@gparlakov
Copy link
Contributor Author

@sashko9807 sorry - it looks like the latest playwright.yaml (addition of keycloak) was ignored - is this a cache thing? Or did I miss something?

image

Notice the command (on the left) was docker-compose up -d pg-db while the update (on the right) includes the keycloak service as well...

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Jul 17, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 17, 2024
@sashko9807
Copy link
Member

@sashko9807 sorry - it looks like the latest playwright.yaml (addition of keycloak) was ignored - is this a cache thing? Or did I miss something?

image

Notice the command (on the left) was docker-compose up -d pg-db while the update (on the right) includes the keycloak service as well...

Probably the keycloak step should be added and merged from a separate commit first.

Though I am not sure whether it would work, because the API container still requires a secret to connect with keycloak. Will have to check whether we can preconfigure it from docker compose first.

@slavcho slavcho marked this pull request as draft July 24, 2024 11:06
@slavcho slavcho added the run tests Allows running the tests workflows for forked repos label Jul 24, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 24, 2024
@gparlakov gparlakov force-pushed the admin-campaign-application-e2e-test branch from 3d12c6a to 4c36c75 Compare August 9, 2024 07:30
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Aug 26, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 26, 2024
@gparlakov gparlakov force-pushed the admin-campaign-application-e2e-test branch from 4c36c75 to 2314f4a Compare September 29, 2024 08:05
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Sep 29, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 29, 2024
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Sep 29, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 29, 2024
- add a login fixture
- add a test that verifies the current admin list of campaign applications
@gparlakov gparlakov force-pushed the admin-campaign-application-e2e-test branch from 2314f4a to a05e37d Compare September 29, 2024 14:30
@gparlakov gparlakov marked this pull request as ready for review September 29, 2024 14:30
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Sep 29, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 29, 2024
@sashko9807 sashko9807 merged commit 742e9b3 into podkrepi-bg:master Sep 29, 2024
11 of 12 checks passed
@slavcho slavcho added the run tests Allows running the tests workflows for forked repos label Sep 30, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 30, 2024
@gparlakov gparlakov deleted the admin-campaign-application-e2e-test branch October 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants