-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add admin campaign applications #1882
chore: add admin campaign applications #1882
Conversation
✅ Tests will run for this PR. Once they succeed it can be merged. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
6193054
to
5b66bea
Compare
E2E job seems to fail. |
Let me see if I can add a step for that keycloak
…On Mon, Jul 15, 2024, 11:14 PM Aleksandar Petkov ***@***.***> wrote:
E2E job seems to fail.
Though im not sure if any auth-based e2e test would ever pass, as we don't
have a job to setup keycloak, which is needed for auth(or at least I don't
see one).
—
Reply to this email directly, view it on GitHub
<#1882 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2SEVZMEYKFRLKEH6XIBY3ZMQUTHAVCNFSM6AAAAABKVEKFECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGMZDANBYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I can't seem to find the run of those (neither unit-tests.yaml or playwright.yaml-s workflow logs show a failed run) @sashko9807 was that run locally or via the actions? |
@sashko9807 sorry - it looks like the latest playwright.yaml (addition of keycloak) was ignored - is this a cache thing? Or did I miss something? Notice the command (on the left) was |
Probably the keycloak step should be added and merged from a separate commit first. Though I am not sure whether it would work, because the API container still requires a secret to connect with keycloak. Will have to check whether we can preconfigure it from docker compose first. |
3d12c6a
to
4c36c75
Compare
4c36c75
to
2314f4a
Compare
- add a login fixture - add a test that verifies the current admin list of campaign applications
2314f4a
to
a05e37d
Compare
Motivation and context
Authentication of a user in e2e tests context
Verification of Admin Campaign Application pages
Testing
run the e2e tests
Environment
New environment variables:
PODKREPI_EMAIL
: email for user authPODKREPI_PASSWORD
: password for user auth