Donation flow more fixes

[sashko9807]

No description provided.

[github-actions]

✅ Tests will run for this PR. Once they succeed it can be merged.

[gparlakov]

LGTM. I've one question - see in comments

[gparlakov]

Is this to assertain that the value is a non-zero number? As in !isNaN(amountWithFees.value) && amountWithFees.value > 0

It's hard to read. And also negative numbers give true value as well => !!-1 === true

[sashko9807]

The idea is to show the text from below only if amountWithFees.value is truthy value. The double negation is needed in order to convert the amountWithFees.value to boolean, otherwise if we just pass amountWithFees.value it would display 0 in the DOM.

[gparlakov]

Yes I get that. What I'm saying is 1 it is unreadable, and 2 it will show the value when it's negative number or a string or an object etc

…

On Wed, Dec 11, 2024, 2:53 PM Aleksandar Petkov ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/components/client/donation-flow/steps/payment-method/TaxesCheckbox.tsx <#1991 (comment)> : > @@ -50,15 +50,17 @@ export const TaxesCheckbox = () => { /> </Grid2> </Grid2> - <Trans - t={t} - i18nKey="step.payment-method.alert.calculated-fees" - values={{ - amount: moneyPublicDecimals2(amountWithoutFees.value), - fees: moneyPublicDecimals2(amountWithFees.value - amountWithoutFees.value), - totalAmount: moneyPublicDecimals2(amountWithFees.value), - }} - /> + {!!amountWithFees.value && ( The idea is to show the text from below only if amountWithFees.value is truthy value. The double negation is needed in order to convert the amountWithFees.value to boolean, otherwise if we just pass amountWithFees.value it would display 0 in the DOM. — Reply to this email directly, view it on GitHub <#1991 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2SEV7N2BRLNQKRIEO3R5L2FAYVLAVCNFSM6AAAAABTFSTYFSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJVGU4DOMBUGU> . You are receiving this because you commented.Message ID: ***@***.***>

[sashko9807]

Yes I get that. What I'm saying is 1 it is unreadable, and 2 it will show the value when it's negative number or a string or an object etc.

Abstracted the condition into its own variable(should be more readable now). As for the other concerns, they aren't really a problem, as the otherAmount field can't accept anything other than positive numbers.