fix: make subscribe dialog responsive #1998
Open
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
reviewed
Dec 24, 2024
| @@ -138,9 +138,6 @@ export default function CampaignDetails({ campaign }: Props) { | |||
| showExpensesLink={(expensesList && expensesList?.length > 0) || canEditCampaign} | |||
| /> | |||
| <Grid container spacing={8}> | |||
| {subscribeIsOpen && ( | |||
| <RenderCampaignSubscribeModal setOpen={setSubscribeOpen} campaign={campaign} /> | |||
There was a problem hiding this comment.
Would you please confirm the removal of this fragment, doesnt cause regression in opening the subscription modal when user clicks on the Subscribe for email notifications for the campaign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made necessary styling changes to make "Subscribe to campaign news" dialog and "general subscribe" dialog responsive.
Closes #{1984}
Screenshots:
Testing
Steps to test
Go to https://podkrepi.bg/
Select a campaign.
Choose "Абонирайте се за email известия за кампанията.". Log in as a guest or with your credentials.
Go to mobile view.
Observe the dialog.