Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up review suggestions for VM launch #953

Closed
cdrage opened this issue Oct 22, 2024 · 0 comments · Fixed by #959
Closed

Follow up review suggestions for VM launch #953

cdrage opened this issue Oct 22, 2024 · 0 comments · Fixed by #959
Assignees
@cdrage
Labels
kind/enhancement ✨ Issue for requesting an improvement

Comments

@cdrage
Copy link
Contributor

cdrage commented Oct 22, 2024

Is your enhancement related to a problem? Please describe

See: #865 (comment)

Follow up to review suggestions

Describe the solution you'd like

Implement suggestions

Describe alternatives you've considered

No response

Additional context

No response
@cdrage cdrage added the kind/enhancement ✨ Issue for requesting an improvement label Oct 22, 2024
@cdrage cdrage self-assigned this Oct 22, 2024
@cdrage cdrage moved this to 🚧 In Progress in Podman Desktop Planning Oct 22, 2024
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Oct 23, 2024
@cdrage
refactor: update vm manager + code suggestions
4a7cfd4 
### What does this PR do?

* Updates the VM manager so that it is more modular
* Fixes suggested code changes
* Updates DiskImageDetailsVirtualMachine check for websocket with a
  timeout.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

N/A

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#953

### How to test this PR?

<!-- Please explain steps to reproduce -->

Everything should work like normal launching a VM for arm or amd64

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage mentioned this issue Oct 23, 2024
Merged
@cdrage cdrage moved this from 🚧 In Progress to 🚥 In Review in Podman Desktop Planning Oct 23, 2024
@cdrage cdrage closed this as completed in 1d65710 Oct 23, 2024
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update vm manager + code suggestions cdrage/podman-desktop-extension-bootc
1 participant
@cdrage