refactor: update vm manager + code suggestions #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? * Updates the VM manager so that it is more modular * Fixes suggested code changes * Updates DiskImageDetailsVirtualMachine check for websocket with a timeout. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#953 ### How to test this PR? <!-- Please explain steps to reproduce --> Everything should work like normal launching a VM for arm or amd64 Signed-off-by: Charlie Drage <[email protected]>
cdrage
requested review from
deboer-tim,
axel7083 and
SoniaSandler
and removed request for
a team
benoitf
approved these changes
Oct 23, 2024
packages/frontend/src/lib/disk-image/DiskImageDetailsVirtualMachine.svelte
Outdated
Show resolved
Hide resolved
…chine.svelte Co-authored-by: Florent BENOIT <[email protected]>
Co-authored-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: update vm manager + code suggestions
What does this PR do?
timeout.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Closes #953
How to test this PR?
Everything should work like normal launching a VM for arm or amd64
Signed-off-by: Charlie Drage [email protected]