Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "implicit optional", e.g. arg: int = None #107

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

amacfie
Copy link
Contributor

@amacfie amacfie commented Mar 2, 2025

The latest version of Pyright makes calling a function with an "implicit optional" a type error. An "implicit optional" is like the following code, where a parameter is annotated with a type that doesn't include None but the default value is None:

def foo(arg: int = None):
    pass

More info here: https://docs.astral.sh/ruff/rules/implicit-optional/

This PR adds typing.Optional where necessary.

@pogzyb pogzyb self-requested a review March 2, 2025 00:46
@pogzyb pogzyb merged commit c7d8896 into pogzyb:main Mar 2, 2025
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants