Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embed endpoint #38

Merged
merged 15 commits into from
Sep 18, 2023
Merged

Fix embed endpoint #38

merged 15 commits into from
Sep 18, 2023

Conversation

FullMetalMeowchemist
Copy link
Contributor

Also addresses parts of #35 by adding coverage

python/starpoint/embedding.py Outdated Show resolved Hide resolved
scottwey
scottwey previously approved these changes Sep 15, 2023
Copy link
Contributor

@scottwey scottwey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but still missing the utility method I think would be very useful.

text_embedding_items = [{"text": text, "metadata": None} for text in texts]
return self.embed_items(text_embedding_items=text_embedding_items, model=model)

def embed_and_join_metadata_by_columns(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one more method where you pass in a field along with a list of dicts like we discussed?

scottwey
scottwey previously approved these changes Sep 16, 2023
Copy link
Contributor

@scottwey scottwey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Brian,

I hope this letter finds you well. This is excellent work. I'm excited to see these changes embedded into our SDK.

Best wishes,
Scott

@FullMetalMeowchemist FullMetalMeowchemist merged commit 2e9cf0a into main Sep 18, 2023
1 check passed
@FullMetalMeowchemist FullMetalMeowchemist deleted the fix-embed-endpoint branch September 18, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants