Add @_transparency attribute to reportIssue(_:_:) default implementation #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Killectro
changed the title
mbrandonw
reviewed
Nov 12, 2024
Comment on lines
93
to
94
| @_transparent | ||
| public func reportIssue( |
There was a problem hiding this comment.
Instead of a new reportIssue can we just mark the existing one as @_transparent? That should also fix the problem.
There was a problem hiding this comment.
That makes a lot more sense. Done!
Killectro
force-pushed
the
runtime-warning-transparency
branch
from
0c3e129
to
0f16b16
Compare
Killectro
changed the title
Killectro
changed the title
mbrandonw
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating the latest versions into our app I noticed #139. The fix here is the copy the default protocol extension implementation of
reportIssue(_:_:)(the one that takes an error as a parameter) inside_RuntimeWarningReporterand add the@_transparentattribute.Verified in my work project that this works as expected! Photos are below (ignore the
attributesparameter, that comes from our wrapper code around this library but doesn't affect the result)