Fix registrar overload resolution #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the `@availability` check we apply to the extension that adds an `Observable` conformance prevents iOS 17+ deployment targets from calling the correct version of `access`, which leads to errant perception checks.
|
While I think we probably could merge this as cleanup, I'm not seeing the overload working consistently across projects, so this branch may not fix the underlying behavior just yet. |
mbrandonw
reviewed
Nov 4, 2024
mbrandonw
approved these changes
Nov 4, 2024
Co-authored-by: Brandon Williams <[email protected]>
stephencelis
added a commit
that referenced
this pull request
Nov 5, 2024
* Fix signature of 'access' method. wip * Fix registrar overload resolution (#104) * Fix registrar overload resolution It looks like the `@availability` check we apply to the extension that adds an `Observable` conformance prevents iOS 17+ deployment targets from calling the correct version of `access`, which leads to errant perception checks. * Update Sources/Perception/Perceptible.swift Co-authored-by: Brandon Williams <[email protected]> --------- Co-authored-by: Brandon Williams <[email protected]> --------- Co-authored-by: Stephen Celis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
@availabilitycheck we apply to the extension that adds anObservableconformance prevents iOS 17+ deployment targets from calling the correct version ofaccess, which leads to errant perception checks.