Fix improper runtime warning for nested closures in GeometryReader #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Hi @ollieatkinson, thank you very much for this! I'm really glad you were able to get a test to show the problem, and the fix seems reasonable to me.
I pushed a few small clean ups, and once it goes green we will merge and release. 🙂
mbrandonw
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #87
Nested closures inside of GeometryReader were being incorrectly reported as runtime warnings because it passed an early
isGeometryTrailingClosurecheck.This resolves the issue by first checking the demangled symbol is not a closure before checking if we are in a geometry reader trailing closure.