Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor widget properties as fields #53

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Refactor widget properties as fields #53

wants to merge 1 commit into from

Conversation

poirierlouis
Copy link
Owner

@poirierlouis poirierlouis commented Nov 4, 2024 •
edited
Loading

Refactor widget properties as fields

26%

Refactor widgets to use a special Field type as properties.

Implemented:

  • defines properties of widgets as fields.
  • adds listener pattern on fields.
  • adds <fig-*-field> component per field.
  • automatically binds field event to declared method in <fig-*-properties>, using syntax on[FieldName]Changed.

Fields:

  • array
    • array-string
  • bool
  • color
  • enum
  • flags
  • float
  • integer
  • number
  • size
  • string

Components:

  • bloc-for
  • button
  • checkbox
  • child-window
  • collapsing-header
  • combo
  • dummy
  • input-color-edit
  • input-number
  • input-text
  • input-textarea
  • label
  • listbox
  • menu-item
  • menu
  • modal
  • plot
  • popup
  • progress-bar
  • radio
  • same-line
  • selectable
  • slider
  • tab-bar
  • tab-item
  • table
  • table-row
  • text
  • tree-node
  • vertical-slider
  • window

Additional notes:
Closes #47

@poirierlouis poirierlouis self-assigned this Nov 4, 2024
@poirierlouis poirierlouis added enhancement New feature or request refactor labels Nov 4, 2024
@poirierlouis poirierlouis changed the title Added fields to widgets Refactor widget properties as fields Nov 4, 2024
@poirierlouis poirierlouis force-pushed the feat/47-add-fields branch 8 times, most recently from 7576359 to 4cbe4d2 Compare November 10, 2024 21:52
@poirierlouis
refactor: add fields to widgets.
05907d4 
Define properties of widgets as fields.
Define <fig-*-field> components to bind widget's field by type.
Update <fig-*-properties> to bind widget's fields using field components.
WIP.

Closes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@poirierlouis poirierlouis

Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define widget properties as individual fields
1 participant
@poirierlouis