Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct examples using suggests packages to run conditionally #78

Merged
merged 18 commits into from
Aug 27, 2024

Conversation

nehill197
Copy link
Member

Conditionally run examples that depend on packages in suggests for sn package.

@nehill197 nehill197 requested a review from aylapear August 23, 2024 17:20
@nehill197 nehill197 self-assigned this Aug 23, 2024
@nehill197 nehill197 requested a review from joethorley August 23, 2024 18:31
@nehill197
Copy link
Member Author

No suggests action is passing now!
I had to add this to the beta-binomial vignette code chunks:
{r eval = requireNamespace("tidyr", "ggplot2", "scales"), .....}

and this to the remaining example that used a suggested package

@examplesIf requireNamespace("hms")
# run example here

@nehill197 nehill197 requested a review from joethorley August 23, 2024 23:19
Copy link
Member

@aylapear aylapear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as all the actions are passing then it sounds good. I would suggest running it through the win builder system just to be certain all systems are passing.

@nehill197 nehill197 merged commit f865b41 into main Aug 27, 2024
34 of 36 checks passed
@nehill197 nehill197 deleted the b-conditional-suggests-5 branch August 27, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants