Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking extras #80

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Checking extras #80

merged 7 commits into from
Sep 17, 2024

Conversation

dunkenwg
Copy link
Contributor

No description provided.

@dunkenwg
Copy link
Contributor Author

Looks like the actions that are failing are doing so because this package depends on R 4.3.0 or later (see DESCRIPTION file)

joethorley
joethorley approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

the actions broke because tests of old versions of R for which the package is not valid were added to the R-CMD-check action.

.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
@joethorley joethorley self-requested a review September 13, 2024 14:47
joethorley
joethorley requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R-CMD-check requires rolling back to previous version.

@dunkenwg dunkenwg requested a review from joethorley September 15, 2024 21:42
nehill197
nehill197 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@nehill197 nehill197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for doing this @dunkenwg

@dunkenwg
Copy link
Contributor Author

No worries!

@nehill197 nehill197 merged commit 15f5161 into main Sep 17, 2024
10 checks passed
@nehill197 nehill197 deleted the before branch September 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehill197 nehill197 nehill197 approved these changes

@joethorley joethorley joethorley approved these changes

Assignees

@nehill197 nehill197

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunkenwg @joethorley @nehill197