Banlist hover #640
Closed
Banlist hover #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think ideally, the "hover note" box is hidden unless "some" is selected, since it turns out that it's not really needed much. But I'm fine with this as is. Thanks for working on it. |
|
I initially left it visible as there was one entry with Edit; would be good to add some basic checking so that |
|
Ok, all done (hiding + check if empty). |
|
Looks good to me, thanks. (tested to check the look/behavior but didn't test an actual ban) |
|
Will try to review this sometime soon ✌️ |
|
Soon never came. Closing as this will also be superceded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582. Changed 'Retrading allowed' to inline radio and added new field:
Result:
