-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODO] @Olshansk's (and now @Bryan's) Blocker TODOs #584
Closed
15 tasks done
Labels
code health
Cleans up some code
on-chain
On-chain business logic
protocol
General core protocol related changes
Milestone
Comments
@bryanchriswhite Any chance you can tend to these in the next iteration? Doesn't seem like I'll have time... |
2 tasks
14 tasks
14 tasks
14 tasks
14 tasks
14 tasks
14 tasks
This was referenced Jul 9, 2024
14 tasks
This was referenced Jul 10, 2024
This was
linked to
pull requests
Jul 10, 2024
14 tasks
14 tasks
14 tasks
13 tasks
Olshansk
added a commit
that referenced
this issue
Jul 24, 2024
Change the difficulty from leading zero bits to to a target hash. - #584 --- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: Redouane Lakrache <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code health
Cleans up some code
on-chain
On-chain business logic
protocol
General core protocol related changes
Objective
Tackle all on-chain blockers assigned to Olshansky
Origin Document
Goals
Deliverables
The output of the following command from #577:
#655
min_relay_difficulty_bits
param #655./pkg/relayer/miner/miner.go
: // TODO_BLOCKER(@Olshansk): query on-chain governance params once available.#656
protocol.CountHashDifficultyBits()
#656./pkg/relayer/miner/miner.go
:// TODO_BLOCKER(@Olshansk): The relay hashing and relay difficulty mechanisms & values must come#629
./x/proof/keeper/msg_server_create_claim.go
: // TODO_BLOCKER(@Olshansk): check if this claim already exists and return an./x/proof/keeper/msg_server_submit_proof.go
: // TODO_BLOCKER(@Olshansk): check if this proof already exists and return an#659
./x/proof/keeper/msg_server_submit_proof.go
: // TODO_BLOCKER(@Olshansk): We need to replace the return#667
grace_period_end_offset_blocks
validation & cleanup #667./x/tokenomics/keeper/msg_update_params.go
: // TODO_BLOCKER(@Olshansk): How do we validate this is the same address that signed the request?./pkg/relayer/proxy/relay_verifier.go
: // TODO_BLOCKER(@Olshansk): Revisit the assumptions above and updated this if./x/session/keeper/session_hydrator.go
: // TODO_BLOCKER(@Olshansk): Retrieve the suppliers at SessionStartBlockHeight,#668
./x/proof/module/query_proof_test.go
:// TODO_BLOCKER(@Olshansk): Add these tests back in after merging on-chain Proof persistence.#669
EventApplicationOverserviced
event #669./x/tokenomics/keeper/settle_session_accounting.go
: // TODO_BLOCKER(@Olshansk): The application should be immediately unstaked at this point in time#670
./x/tokenomics/keeper/settle_session_accounting_test.go
: t.Skip("TODO_BLOCKER(@Olshansk): Add E2E and integration tests so we validate the actual state changes of the bank & account keepers.")./x/tokenomics/keeper/settle_session_accounting_test.go
: t.Skip("TODO_BLOCKER(@Olshansk): Add E2E and integration tests so we validate the actual state changes of the bank & account keepers.")#656
protocol.CountHashDifficultyBits()
#656./pkg/relayer/protocol/difficulty.go
:// TODO_BLOCKER(@Olshansk): Remove the forloop logic and replace with a simplified#671
./x/tokenomics/keeper/settle_pending_claims.go
: // TODO_BLOCKER(@Olshansk): Optimize this by indexing expiringClaims appropriatelypokt-network/smt#50, pokt-network/smt#51, & #672
smt.MerkleRoot#Sum()
error handling #672./x/tokenomics/keeper/settle_session_accounting.go
: // TODO_BLOCKER(@Olshansk): This check should be the responsibility of the SMST packageCreator: @Olshansk
The text was updated successfully, but these errors were encountered: