-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODOs] grace_period_end_offset_blocks
validation & cleanup
#667
Conversation
WalkthroughThe recent updates focus on refining validation logic, clarifying error messages, and cleaning up code comments across various modules. Key changes include enhancing parameter validation in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
grace_period_end_offset_blocks
validation & cleanup
The image is going to be pushed after the next commit. You can use If you also want to run E2E tests, please add |
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 667) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- x/shared/types/params.go (4 hunks)
- x/tokenomics/keeper/msg_update_params.go (1 hunks)
Files skipped from review due to trivial changes (1)
- x/tokenomics/keeper/msg_update_params.go
Additional comments not posted (3)
x/shared/types/params.go (3)
116-119
: LGTM! Ensure that the added validation functions are correctly integrated.The addition of
validateGracePeriodOffsetBlocksIsLessThanNumBlocksPerSession
andvalidateClaimWindowOpenOffsetIsAtLeastGracePeriodEndOffset
in theValidateBasic
method looks good.However, verify that these validation functions are correctly integrated into the larger codebase.
Line range hint
182-195
:
LGTM! Ensure the godoc comment is clear and complete.The function
validateClaimWindowOpenOffsetIsAtLeastGracePeriodEndOffset
correctly validates thatClaimWindowOpenOffsetBlocks
is at least as large asGracePeriodEndOffsetBlocks
.However, verify that the godoc comment is clear and complete.
197-206
: LGTM! Ensure the godoc comment is clear and complete.The function
validateGracePeriodOffsetBlocksIsLessThanNumBlocksPerSession
correctly validates thatGracePeriodEndOffsetBlocks
is less thanNumBlocksPerSession
.However, verify that the godoc comment is clear and complete.
(cherry picked from commit d3bd78a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pkg/relayer/proxy/relay_verifier.go (1 hunks)
Additional comments not posted (3)
pkg/relayer/proxy/relay_verifier.go (3)
68-73
: Good use of getter methods for session IDs.The change improves encapsulation and code readability.
Line range hint
52-54
:
Clear and concise comment onapplicationAddress
.The revised comment provides a better understanding of the guarantee provided by the relay request signature verification.
Line range hint
1-93
:
Overall changes are consistent and improve code quality.The changes integrate well with the existing code, improving encapsulation and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pkg/relayer/proxy/proxy_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- pkg/relayer/proxy/proxy_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/session/keeper/session_hydrator.go (1 hunks)
Files skipped from review due to trivial changes (1)
- x/session/keeper/session_hydrator.go
@@ -163,11 +163,6 @@ func (k Keeper) hydrateSessionApplication(ctx context.Context, sh *sessionHydrat | |||
func (k Keeper) hydrateSessionSuppliers(ctx context.Context, sh *sessionHydrator) error { | |||
logger := k.Logger().With("method", "hydrateSessionSuppliers") | |||
|
|||
// TODO_BLOCKER(@Olshansk): Retrieve the suppliers at SessionStartBlockHeight, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved by #666 👹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments worth discussing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The image is going to be pushed after the next commit. You can use If you also want to run E2E tests, please add |
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 667) |
…ation-overserviced * pokt/main: [TODO] Blockers @okdas (#674) [TODO_BLOCKER] chore: Remove stale TODO_BLOCKERs (#694) [TODO] refactor: query expiring claims w/ index (#671) [TODOs] `grace_period_end_offset_blocks` validation & cleanup (#667) [Testing] add account balance coverage to account settlement (#670) [Application] Auto-undelegation of unstaked gateways (#692) [RelayMiner] Fix LeanClient mutiple suppliers support (#662)
…-root * pokt/main: [TODO] Blockers @okdas (#674) [TODO_BLOCKER] chore: Remove stale TODO_BLOCKERs (#694) [TODO] refactor: query expiring claims w/ index (#671) [TODOs] `grace_period_end_offset_blocks` validation & cleanup (#667) [Testing] add account balance coverage to account settlement (#670) [Application] Auto-undelegation of unstaked gateways (#692) [RelayMiner] Fix LeanClient mutiple suppliers support (#662)
Summary
grace_period_end_offset_blocks
validation.cosmos.msg.v1.signer
protobuf option, see: Support cosmos.msg.v1.signer as alternative to Msg.GetSigners cosmos/cosmos-sdk#11275 (comment).Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist
Summary by CodeRabbit
Bug Fixes
Refactor
Tests
Chores