Objective

Tackle all on-chain blockers assigned to Olshansky

Origin Document

• [TODO] Team's Iteration16 TODO preparation #577
  

Goals

• Tackle all major TODO's in the codebase assigned to Olshansky

Deliverables

The output of the following command from #577:

grep -r "TODO_BLOCKER(@Olshansk)" . | sed 's/^/- [ ] `/' | sed 's/:/`:/'

#655

• [Relayminer] refactor: query min_relay_difficulty_bits param #655
• ./pkg/relayer/miner/miner.go: // TODO_BLOCKER(@Olshansk): query on-chain governance params once available.

#656

• [Code Health] refactor: simplify protocol.CountHashDifficultyBits() #656
• ./pkg/relayer/miner/miner.go:// TODO_BLOCKER(@Olshansk): The relay hashing and relay difficulty mechanisms & values must come

#629

• [On-Chain] Claim/Proof on-chain events #629
• ./x/proof/keeper/msg_server_create_claim.go: // TODO_BLOCKER(@Olshansk): check if this claim already exists and return an
• ./x/proof/keeper/msg_server_submit_proof.go: // TODO_BLOCKER(@Olshansk): check if this proof already exists and return an

#659

• [TODOs] refactor: proof path calculation #659
• ./x/proof/keeper/msg_server_submit_proof.go: // TODO_BLOCKER(@Olshansk): We need to replace the return

#667

• [TODOs] grace_period_end_offset_blocks validation & cleanup #667
• ./x/tokenomics/keeper/msg_update_params.go: // TODO_BLOCKER(@Olshansk): How do we validate this is the same address that signed the request?
• ./pkg/relayer/proxy/relay_verifier.go: // TODO_BLOCKER(@Olshansk): Revisit the assumptions above and updated this if
• ./x/session/keeper/session_hydrator.go: // TODO_BLOCKER(@Olshansk): Retrieve the suppliers at SessionStartBlockHeight,

#668

• [Testing] chore: uncomment proof CLI query tests #668
• ./x/proof/module/query_proof_test.go:// TODO_BLOCKER(@Olshansk): Add these tests back in after merging on-chain Proof persistence.

#669

• [TODOs] add EventApplicationOverserviced event #669
• ./x/tokenomics/keeper/settle_session_accounting.go: // TODO_BLOCKER(@Olshansk): The application should be immediately unstaked at this point in time

#670

• [Testing] add account balance coverage to account settlement #670
• ./x/tokenomics/keeper/settle_session_accounting_test.go: t.Skip("TODO_BLOCKER(@Olshansk): Add E2E and integration tests so we validate the actual state changes of the bank & account keepers.")
• ./x/tokenomics/keeper/settle_session_accounting_test.go: t.Skip("TODO_BLOCKER(@Olshansk): Add E2E and integration tests so we validate the actual state changes of the bank & account keepers.")

#656

• [Code Health] refactor: simplify protocol.CountHashDifficultyBits() #656
• ./pkg/relayer/protocol/difficulty.go:// TODO_BLOCKER(@Olshansk): Remove the forloop logic and replace with a simplified

#671

• [TODO] refactor: query expiring claims w/ index #671
• ./x/tokenomics/keeper/settle_pending_claims.go: // TODO_BLOCKER(@Olshansk): Optimize this by indexing expiringClaims appropriately

pokt-network/smt#50, pokt-network/smt#51, & #672

• refactor: MerkleRoot#Sum() as MerkleRoot#MustSum() smt#50
• [Code Health] refactor: SMST#Root(), #Sum(), & #Count() smt#51
• [TODO] chore: update smt.MerkleRoot#Sum() error handling #672
• ./x/tokenomics/keeper/settle_session_accounting.go: // TODO_BLOCKER(@Olshansk): This check should be the responsibility of the SMST package

Creator: @Olshansk