Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Morse->Shannon Migration] implement MsgClaimMorseApplication handler #1082

Open
wants to merge 39 commits into
base: issues/1034/refactor/stake_app
Choose a base branch
from
Open

[Morse->Shannon Migration] implement MsgClaimMorseApplication handler #1082

wants to merge 39 commits into from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Feb 19, 2025 •
edited
Loading

Summary

Implement MsgClaimMorseApplication message handler. It should stake, or upstake and replace the service config, a Shannon application, given a previously imported (and unclaimed) MorseClaimableAccount.

Issue

Type of change

Select one or more from the following:

Sanity Checklist

  • I have updated the GitHub Issue assignees, reviewers, labels, project, iteration and milestone
  • For docs, I have run make docusaurus_start
  • For code, I have run make go_develop_and_test and make test_e2e
  • For code, I have added the devnet-test-e2e label to run E2E tests in CI
  • For configurations, I have update the documentation
  • I added TODOs where applicable

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. migration Morse to Shannon migration related work labels Feb 19, 2025
@bryanchriswhite bryanchriswhite self-assigned this Feb 19, 2025
github-actions[bot]
github-actions bot reviewed Feb 19, 2025
View reviewed changes
@bryanchriswhite bryanchriswhite changed the base branch from main to issues/1034/scaffold/msg_claim_morse_application February 19, 2025 12:23
@bryanchriswhite bryanchriswhite mentioned this pull request Feb 19, 2025
Open
13 tasks
@bryanchriswhite bryanchriswhite force-pushed the issues/1034/feat/claim_morse_app branch from 2a45bae to a1e15ae Compare February 19, 2025 17:12
@bryanchriswhite bryanchriswhite mentioned this pull request Feb 24, 2025
Open
12 tasks
@bryanchriswhite bryanchriswhite changed the base branch from issues/1034/scaffold/msg_claim_morse_application to issues/1034/refactor/stake_app February 26, 2025 10:28
@bryanchriswhite bryanchriswhite force-pushed the issues/1034/feat/claim_morse_app branch 4 times, most recently from 30f5a69 to 3fab44d Compare February 26, 2025 14:37
@bryanchriswhite bryanchriswhite force-pushed the issues/1034/feat/claim_morse_app branch from 3fab44d to 3ace82c Compare February 26, 2025 16:26
bryanchriswhite
bryanchriswhite commented Feb 26, 2025
View reviewed changes
tests/integration/migration/morse_claim_account_test.go
"github.com/pokt-network/poktroll/testutil/sample"
migrationtypes "github.com/pokt-network/poktroll/x/migration/types"
)

type MigrationModuleTestSuite struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reviewer, this section was moved to morse_import_test.go

Olshansk
Olshansk requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a partial review and will TAL after some of the changes are addressed.

Since I reviewed #1095 BEFORE #1082, please tend to that one first.

@bryanchriswhite
chore: review feedback improvements
5753cfa
@bryanchriswhite
chore: regenerate protobufs
3c0d469
@bryanchriswhite
wip...
384b021
@bryanchriswhite
Merge remote-tracking branch 'pokt/issues/1034/refactor/stake_app' in…
14edfd4 
…to issues/1034/feat/claim_morse_app

* pokt/issues/1034/refactor/stake_app:
  self-review improvements
  chore: review feedback improvements
  fix: typo
  chore: review feedback improvements
  chore: self-review improvements
  chore: regenerate protobufs
  chore: review feedback improvements
  chore: regenerate protobufs
  chore: review feedback improvements
  chore: review feedback improvements
  refactor: MorseStateExport & MorseClaimableAccount fixtures
  [RelayMiner] Implement relayminer query caching (#1050)
@bryanchriswhite
wip
2dd8780
@bryanchriswhite
wip: juggling
5895b03
@bryanchriswhite
fix: cleanup test cache
8ab1824
@bryanchriswhite
chore: cleanup app-integration test
ffe6968
@bryanchriswhite
Merge remote-tracking branch 'pokt/issues/1034/refactor/stake_app' in…
2997d23 
…to issues/1034/feat/claim_morse_app

* pokt/issues/1034/refactor/stake_app:
  [Morse->Shannon Migration] s/`QueryGetMorseClaimable(.+)`/`QueryMorseClaimable$1`/g (#1076)
  [Morse->Shannon Migration] feat: implement claim Morse account (#1059)
@bryanchriswhite
removeme: after #1108 is merged
6307dc8 
#1108
(cherry picked from commit 373d33d90392f4cc01beefddd9d1932b613ade79)
@bryanchriswhite
chore: comments
3523697
@bryanchriswhite
test: refactor minStake
19dca18
@bryanchriswhite bryanchriswhite requested a review from Olshansk March 7, 2025 11:18
@bryanchriswhite bryanchriswhite mentioned this pull request Mar 7, 2025
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@red-0ne red-0ne Awaiting requested review from red-0ne

@Olshansk Olshansk Awaiting requested review from Olshansk

Assignees

@bryanchriswhite bryanchriswhite

Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. migration Morse to Shannon migration related work on-chain On-chain business logic
Projects
Shannon
Status: 👀 In review
Milestone
Beta TestNet Iteration
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanchriswhite @Olshansk